Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISC] battery_ok discovery differentiation #1958

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

DigiH
Copy link
Collaborator

@DigiH DigiH commented May 30, 2024

Differentiation between 0%-100% float battery_ok devices' discovery and binary_sensor devices battery_ok

battery_ok binary_sensor
image
image

battery_ok float
image

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@DigiH DigiH requested a review from 1technophile May 30, 2024 23:41
@DigiH DigiH force-pushed the battery_ok branch 2 times, most recently from 65251b9 to 882b569 Compare May 30, 2024 23:56
@DigiH
Copy link
Collaborator Author

DigiH commented May 31, 2024

The one issue remaining, not quite breaking, but slightly confusing, is that previous wrong battery_ok sensor % discoveries do not get overwritten by the new binary_sensor battery_ok discovery, but they exist alongside each other until the sensor % discovery entry is manually deleted, or the whole MQTT integration device is being deleted and discovered afresh.

Still very much worth it for proper battery_ok discovery in my opinion.

Differentiation between 0%-100% float battery_ok devices' discovery and binary_sensor devices battery_ok
@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 6e90670 into development Jun 10, 2024
144 checks passed
@1technophile 1technophile deleted the battery_ok branch June 10, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants