Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env for Lolin Wemos D1 mini with CC1101 #1716

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

vi7
Copy link
Contributor

@vi7 vi7 commented Jul 15, 2023

Description:

  1. Add env for Lolin (Wemos) D1 Mini with CC1101 transceiver

Network related parameters (-DNET_IP etc.) are dependant on the feature delivered by #1715

NOTE: My editor automatically fixed some redundant spaces. Pls let me know if this is not needed

Checklist:

  • The pull request is done against the latest development branch
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • I accept the DCO.

@vi7 vi7 force-pushed the wemos_d1_mini_cc1101_env branch from 2340329 to 0f6ce06 Compare August 9, 2023 21:08
@1technophile
Copy link
Owner

Thanks for the PR. I'm not sure of the value of adding a new environment for CC1101 and an ESP8266 based board, as we have already nodemcuv2-rf-cc1101

Do you know that you can store your environment into a prod_env.ini file separate from environments.ini ?

@vi7
Copy link
Contributor Author

vi7 commented Aug 11, 2023

@1technophile yep, prod_env.ini is exactly how I'm using it right now. The reason for the PR is that nodemcuv2-rf-cc1101 appeared to be incompatible with Wemos D1 mini boards as-is, so I thought dedicated env could be helpful for people who are using D1 mini board.

I'm ok with any decision from your side however.

@1technophile
Copy link
Owner

1technophile commented Sep 6, 2023

Let's add it as an example only in this case (commented)

@vi7 vi7 force-pushed the wemos_d1_mini_cc1101_env branch 2 times, most recently from dddf83b to f8dd60a Compare September 25, 2023 13:31
@vi7 vi7 force-pushed the wemos_d1_mini_cc1101_env branch from f8dd60a to 57e5295 Compare September 25, 2023 13:35
@vi7
Copy link
Contributor Author

vi7 commented Sep 25, 2023

@1technophile I've moved D1 mini example to the prod_env.ini.example file

@1technophile
Copy link
Owner

Thanks

@1technophile 1technophile merged commit 3d20995 into 1technophile:development Sep 25, 2023
@vi7 vi7 deleted the wemos_d1_mini_cc1101_env branch September 25, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants