Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mi Flora consistent MQTT protocol #201

Closed
torwag opened this issue May 7, 2018 · 3 comments
Closed

Mi Flora consistent MQTT protocol #201

torwag opened this issue May 7, 2018 · 3 comments
Milestone

Comments

@torwag
Copy link
Contributor

torwag commented May 7, 2018

I just noticed that the RSSI value is send by e.g. :

home/BTtoMQTT/445F3666113E -085

whereas all other data is send by adding a subtopic e.g.:

home/BTtoMQTT/445F3666113E/temp 20.0
home/BTtoMQTT/445F3666113E/moi 10
home/BTtoMQTT/445F3666113E/lux 500

This makes it unnecessary difficult to parse the MQTT topic, as it is not consistent.
If the RSSI value will be send in the same way e.g.:

home/BTtoMQTT/445F3666113E/rssi -085

parsing would be easier and the meaning of the payload would be more clear to beginners.

@1technophile 1technophile added this to the v0.8 milestone May 8, 2018
1technophile added a commit that referenced this issue May 12, 2018
#201 and put defines for other sub subject names
@1technophile
Copy link
Owner

@torwag could you test the changes from master and say me if ok for you?

@torwag
Copy link
Contributor Author

torwag commented May 20, 2018

Looks good to me, flashed a second board with the new code and it seems to work as desired.
I created a fork and did the changes myself, however, did not had time to test them and create a PR.
BTW. I couldn't find how the trc command is used. Seems to be a debug command, but couldn't find any infos about it.

For releasing, it might be a good idea to publish both statements (old way and new way) for the next release and announce in the changelog, that the old way will be deprecated with the next release. This gives people time to adust their code to the new system.

Thanks for the changes.

@1technophile
Copy link
Owner

Yes trc is a debug command that can be deactivated in user config. It enbles to see the traces on the serial monitor.

1technophile added a commit that referenced this issue Jun 8, 2018
#201
and comment the mac + rssi behaviour
will be put per default on next version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants