Skip to content

Commit

Permalink
Remove unnecessary macro (#1348)
Browse files Browse the repository at this point in the history
This macro is not necessary to add per environment as it is present into com-esp as a global macro for all ESP, also modifying nodemcuv2-mqtt-fw-test env to test self signed only. Removing env:esp32dev-mqtt-fw-test as self signed cert are already tested into env:esp32dev-ble-aws.

Co-authored-by: Florian <[email protected]>
  • Loading branch information
1technophile and 1technophile authored Dec 7, 2022
1 parent 4e69938 commit 47108d8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
- "ttgo-t-beam"
- "heltec-wifi-lora-32-868"
- "heltec-wifi-lora-32-915"
- "esp32dev-mqtt-fw-test"
- "nodemcuv2-all-test"
- "nodemcuv2-fastled-test"
- "nodemcuv2-2g"
Expand Down
15 changes: 1 addition & 14 deletions platformio.ini
Original file line number Diff line number Diff line change
Expand Up @@ -992,19 +992,6 @@ build_flags =
'-DTimeLedON=0.1'
'-DLED_SEND_RECEIVE_ON=1'

[env:esp32dev-mqtt-fw-test]
platform = ${com.esp32_platform}
board = esp32dev
lib_deps =
${com-esp.lib_deps}
${libraries.wifimanager32}
build_flags =
${com-esp.build_flags}
'-DMQTT_HTTPS_FW_UPDATE'
'-DMQTT_SECURE_SELF_SIGNED'
'-DGateway_Name="OpenMQTTGateway_TEST_MQTT_FW"'
board_build.flash_mode = dout

[env:nodemcuv2-all-test]
platform = ${com.esp8266_platform}
board = nodemcuv2
Expand Down Expand Up @@ -1216,7 +1203,7 @@ lib_deps =
${libraries.wifimanager8266}
build_flags =
${com-esp.build_flags}
'-DMQTT_HTTPS_FW_UPDATE'
'-DMQTT_SECURE_SELF_SIGNED'
'-DGateway_Name="OpenMQTTGateway_TEST_MQTT_FW"'
board_build.flash_mode = dout

Expand Down

0 comments on commit 47108d8

Please sign in to comment.