Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): incorrect prettier parser inferred for angular html files #133

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jul 14, 2022

No description provided.

@JounQin JounQin added the bug Something isn't working label Jul 14, 2022
@JounQin JounQin requested a review from EdisonSu768 July 14, 2022 08:39
@JounQin JounQin self-assigned this Jul 14, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: ce85581

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@1stg/app-config Patch
@1stg/common-config Patch
@1stg/eslint-config Patch
@1stg/lib-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

📊 Package size report   0.5%↑

File Before After
.changeset/wicked-panthers-kiss.md 190 B
.eslintignore 65 B 5%↑68 B
.prettierignore 16 B
packages/eslint-config/overrides.js 13.3 kB 0.9%↑13.4 kB
pnpm-lock.yaml 543.0 kB 0.9%↑547.9 kB
Total (Includes all files) 972.6 kB 0.5%↑977.8 kB
Tarball size 243.8 kB 0.5%↑244.9 kB
Unchanged files
File Size
.browserslistrc 41 B
.changeset/config.json 311 B
.changeset/README.md 510 B
.codesandbox/ci.json 105 B
.commitlintrc 35 B
.editorconfig 161 B
.eslintrc 206 B
.github/FUNDING.yml 195 B
.github/workflows/ci.yml 1.0 kB
.github/workflows/pkg-size.yml 467 B
.github/workflows/release.yml 1.3 kB
.lintstagedrc.js 50 B
.markuplintrc 51 B
.nvmrc 6 B
.postcssrc.js 49 B
.prettierrc 24 B
.remarkrc 49 B
.renovaterc 35 B
.simple-git-hooks.js 51 B
.stylelintignore 131 B
.stylelintrc 90 B
CHANGELOG.md 1.3 kB
LICENSE 1.1 kB
package.json 2.5 kB
packages/app-config/CHANGELOG.md 35.2 kB
packages/app-config/package.json 1.6 kB
packages/app-config/README.md 2.8 kB
packages/babel-preset/CHANGELOG.md 20.1 kB
packages/babel-preset/config.js 43 B
packages/babel-preset/index.js 5.4 kB
packages/babel-preset/package.json 2.1 kB
packages/babel-preset/README.md 2.8 kB
packages/browserslist-config/alauda-legacy.js 51 B
packages/browserslist-config/alauda.js 133 B
packages/browserslist-config/CHANGELOG.md 5.4 kB
packages/browserslist-config/index.js 65 B
packages/browserslist-config/latest.js 49 B
packages/browserslist-config/modern.js 169 B
packages/browserslist-config/package.json 1.2 kB
packages/browserslist-config/README.md 2.8 kB
packages/commitlint-config/CHANGELOG.md 11.3 kB
packages/commitlint-config/index.js 557 B
packages/commitlint-config/package.json 1.3 kB
packages/commitlint-config/README.md 2.8 kB
packages/common-config/CHANGELOG.md 29.1 kB
packages/common-config/package.json 1.8 kB
packages/common-config/README.md 2.8 kB
packages/config/CHANGELOG.md 1.0 kB
packages/config/index.js 510 B
packages/config/package.json 1.1 kB
packages/config/README.md 2.8 kB
packages/eslint-config/_util.js 1.3 kB
packages/eslint-config/base.js 3.0 kB
packages/eslint-config/CHANGELOG.md 45.2 kB
packages/eslint-config/index.js 118 B
packages/eslint-config/loose.js 1.2 kB
packages/eslint-config/package.json 3.0 kB
packages/eslint-config/README.md 2.8 kB
packages/eslint-config/recommended.js 30 B
packages/husky-config/CHANGELOG.md 6.8 kB
packages/husky-config/index.js 122 B
packages/husky-config/package.json 1.2 kB
packages/husky-config/README.md 2.8 kB
packages/lib-config/CHANGELOG.md 32.3 kB
packages/lib-config/package.json 1.4 kB
packages/lib-config/README.md 2.8 kB
packages/lint-staged/_utils.js 429 B
packages/lint-staged/base.js 1.2 kB
packages/lint-staged/CHANGELOG.md 25.1 kB
packages/lint-staged/index.js 35 B
packages/lint-staged/ngc.js 207 B
packages/lint-staged/package.json 1.4 kB
packages/lint-staged/README.md 2.8 kB
packages/lint-staged/tsc.js 188 B
packages/lint-staged/vue-tsc.js 237 B
packages/markuplint-config/angular.js 107 B
packages/markuplint-config/base.js 231 B
packages/markuplint-config/CHANGELOG.md 3.6 kB
packages/markuplint-config/index.js 35 B
packages/markuplint-config/package.json 1.5 kB
packages/markuplint-config/README.md 2.8 kB
packages/markuplint-config/svelte.js 107 B
packages/markuplint-config/vue.js 136 B
packages/postcss-config/CHANGELOG.md 14.2 kB
packages/postcss-config/index.js 1.1 kB
packages/postcss-config/package.json 1.5 kB
packages/postcss-config/README.md 2.8 kB
packages/prettier-config/angular.js 214 B
packages/prettier-config/base.js 1.0 kB
packages/prettier-config/CHANGELOG.md 20.8 kB
packages/prettier-config/index.js 35 B
packages/prettier-config/next.js 224 B
packages/prettier-config/package.json 1.6 kB
packages/prettier-config/quote.js 62 B
packages/prettier-config/README.md 2.8 kB
packages/prettier-config/semi/angular.js 58 B
packages/prettier-config/semi/index.js 55 B
packages/prettier-config/semi/quote.js 56 B
packages/prettier-config/semi/vue.js 54 B
packages/prettier-config/svelte.js 213 B
packages/prettier-config/vue.js 210 B
packages/remark-config/CHANGELOG.md 5.7 kB
packages/remark-config/index.js 1.1 kB
packages/remark-config/package.json 1.7 kB
packages/remark-config/README.md 2.8 kB
packages/renovate-config/CHANGELOG.md 3.5 kB
packages/renovate-config/package.json 1.4 kB
packages/renovate-config/README.md 2.8 kB
packages/simple-git-hooks/CHANGELOG.md 1.7 kB
packages/simple-git-hooks/index.js 200 B
packages/simple-git-hooks/package.json 1.3 kB
packages/simple-git-hooks/README.md 2.8 kB
packages/stylelint-config/_overrides.js 1.2 kB
packages/stylelint-config/base.js 1.3 kB
packages/stylelint-config/CHANGELOG.md 18.9 kB
packages/stylelint-config/index.js 43 B
packages/stylelint-config/loose.js 47 B
packages/stylelint-config/modules.js 175 B
packages/stylelint-config/package.json 1.8 kB
packages/stylelint-config/README.md 2.8 kB
packages/stylelint-config/scss/base.js 1.2 kB
packages/stylelint-config/scss/index.js 35 B
packages/stylelint-config/scss/loose.js 287 B
packages/tsconfig/angular.json 306 B
packages/tsconfig/app.json 244 B
packages/tsconfig/CHANGELOG.md 8.4 kB
packages/tsconfig/dom-lib.json 158 B
packages/tsconfig/lib.json 161 B
packages/tsconfig/loose.json 180 B
packages/tsconfig/ng-lib.json 387 B
packages/tsconfig/node.json 136 B
packages/tsconfig/node16.json 168 B
packages/tsconfig/nodenext.json 170 B
packages/tsconfig/package.json 1.2 kB
packages/tsconfig/README.md 2.8 kB
packages/tsconfig/tsconfig.json 580 B
pnpm-workspace.yaml 25 B
README.md 4.1 kB
tests/_test.ts 1.1 kB
tests/test.component.html 142 B
tests/test.component.ts 198 B
tests/test.css 53 B
tests/test.d.ts 409 B
tests/test.html 191 B
tests/test.js 679 B
tests/test.json 23 B
tests/test.json5 22 B
tests/test.jsonc 36 B
tests/test.less 318 B
tests/test.md 61 B
tests/test.mdx 143 B
tests/test.pug 17 B
tests/test.scss 300 B
tests/test.sh 20 B
tests/test.spec.js 129 B
tests/test.spec.ts 667 B
tests/test.styl 286 B
tests/test.svelte 380 B
tests/test.svg 1.2 kB
tests/test.toml 16 B
tests/test.vue 436 B
tests/test.yaml 13 B
tests/test.yml 13 B
tests/test1.jsx 347 B
tests/test2.ts 1.5 kB
tests/test3.tsx 386 B
tsconfig.json 41 B

🤖 This report was automatically generated by pkg-size-action

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #133 (ce85581) into master (e5a641e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files           3        3           
  Lines          74       74           
  Branches       39       39           
=======================================
  Hits           40       40           
  Misses         30       30           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a641e...ce85581. Read the comment docs.

Copy link
Contributor

@EdisonSu768 EdisonSu768 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JounQin JounQin merged commit 9db70a5 into master Jul 14, 2022
@JounQin JounQin deleted the fix/prettier_angular branch July 14, 2022 08:48
@pr-triage pr-triage bot added the PR: merged label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants