Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multi-threading via the ThreadsX package #3

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Conversation

1oly
Copy link
Owner

@1oly 1oly commented Jun 1, 2022

Enabling multi-threading via ThreadsX.jl package and the trick demonstrated by @oxinabox in this discourse thread.

A global setting in Environment enables speed-ups when julia is starting with multiple threads, e.g. julia -t auto. A benchmark comparing 1 and 8 threads shows speeds ups:

  • steeringvectors 2.5X
  • beamforming 4X
  • psf 0.8X (a speed-down, so multi-threading is default disabled for this function)
  • cleanSC 3X

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #3 (6051358) into master (5aaa332) will increase coverage by 0.38%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   73.63%   74.01%   +0.38%     
==========================================
  Files          11       11              
  Lines         402      408       +6     
==========================================
+ Hits          296      302       +6     
  Misses        106      106              
Impacted Files Coverage Δ
src/AeroAcoustics.jl 70.96% <ø> (+3.11%) ⬆️
src/fista.jl 100.00% <ø> (ø)
src/types.jl 66.66% <ø> (ø)
src/steeringvectors.jl 14.70% <50.00%> (+1.27%) ⬆️
src/beamforming.jl 100.00% <100.00%> (ø)
src/cleansc.jl 78.72% <100.00%> (+0.46%) ⬆️
src/psf.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aaa332...6051358. Read the comment docs.

@1oly 1oly merged commit e834c50 into master Jun 1, 2022
@1oly 1oly deleted the multithread branch June 1, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant