Использование serverInfo.version как release name в Sentry

[nixel2007]

Описание

Связанные задачи

Closes

Чеклист

Общие

• Ветка PR обновлена из develop
• Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
• Изменения покрыты тестами
• Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

• Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

[coderabbitai]

Walkthrough

В пулл-реквесте изменён класс конфигурации Sentry, добавлено новое поле sentryProperties из io.sentry.spring.boot.jakarta, используется для установки версии релиза через вызов serverInfo.getVersion() в методе init. Аналогичное правило настроено в нескольких конфигурационных файлах, где добавлено свойство sentry.use-git-commit-id-as-release=false, что указывает на использование заданного идентификатора релиза вместо Git commit ID.

Changes

Файл(ы)	Описание изменений
src/main/java/.../SentryScopeConfigurer.java	Добавлено поле private final SentryProperties sentryProperties;; обновлён метод init для установки версии релиза через sentryProperties.setRelease(serverInfo.getVersion()).
src/main/resources/application.properties src/test/resources/application-measures.properties src/test/resources/application-websocket.properties src/test/resources/application.properties	Добавлено новое свойство: sentry.use-git-commit-id-as-release=false.

Sequence Diagram(s)

sequenceDiagram
    participant C as SentryScopeConfigurer
    participant S as ServerInfo
    participant P as SentryProperties

    C->>S: Получить версию
    S-->>C: Вернуть версию
    C->>P: Установить release(version)

Loading

Poem

Я кролик, весёл и проворен,
Прыгаю в код, как в поле морковок,
Изменения блестят, словно звёзды в небесах,
Sentry с версией засиял, как рассвет в лесах,
Пусть баги тают, а код всегда радует всех нас!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0a3fe0 and b584c6d.

📒 Files selected for processing (5)

• src/main/java/com/github/_1c_syntax/bsl/languageserver/aop/sentry/SentryScopeConfigurer.java (3 hunks)
• src/main/resources/application.properties (1 hunks)
• src/test/resources/application-measures.properties (1 hunks)
• src/test/resources/application-websocket.properties (1 hunks)
• src/test/resources/application.properties (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: build (23, windows-latest)
• GitHub Check: build (23, ubuntu-latest)
• GitHub Check: build (21, macOS-latest)
• GitHub Check: build (21, windows-latest)
• GitHub Check: build (21, ubuntu-latest)
• GitHub Check: build (17, macOS-latest)
• GitHub Check: build
• GitHub Check: build (17, windows-latest)
• GitHub Check: Analyse
• GitHub Check: build (17, ubuntu-latest)
• GitHub Check: Benchmark
• GitHub Check: build (23, macOS-latest)
• GitHub Check: build (23, windows-latest)
• GitHub Check: build (23, ubuntu-latest)
• GitHub Check: build (21, macOS-latest)
• GitHub Check: build (21, windows-latest)
• GitHub Check: build (21, ubuntu-latest)
• GitHub Check: build (17, macOS-latest)
• GitHub Check: build (17, windows-latest)
• GitHub Check: build (17, ubuntu-latest)

🔇 Additional comments (6)

src/main/java/com/github/_1c_syntax/bsl/languageserver/aop/sentry/SentryScopeConfigurer.java (2)

27-27: Корректное добавление зависимости SentryProperties

Добавление зависимости и поля для SentryProperties выполнено корректно с использованием конструктора через @requiredargsconstructor.

Also applies to: 49-49

---

60-61: Правильная установка версии релиза

Использование serverInfo.getVersion() для установки версии релиза в Sentry полностью соответствует целям PR и является хорошим решением для отслеживания версий.

src/main/resources/application.properties (1)

24-24: Корректная настройка идентификатора релиза

Отключение использования Git commit ID в качестве идентификатора релиза согласуется с реализацией использования serverInfo.version.

src/test/resources/application-websocket.properties (1)

24-24: Согласованность конфигурации в тестовой среде

Настройка Sentry в тестовой конфигурации websocket согласована с основной конфигурацией приложения.

src/test/resources/application.properties (1)

25-25: Полная согласованность конфигурации

Настройка Sentry согласована во всех конфигурационных файлах, что обеспечивает единообразное поведение во всех средах выполнения.

src/test/resources/application-measures.properties (1)

26-26: Проверка нового свойства Sentry.

Добавленное свойство sentry.use-git-commit-id-as-release=false корректно задаёт использование serverInfo.version в качестве имени релиза в Sentry вместо Git commit ID. Убедитесь, что аналогичные изменения внесены во все остальные файлы конфигурации (например, в application.properties и application-websocket.properties) для единообразия настройки.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Qodana for JVM

78 new problems were found

Inspection name	Severity	Problems
Field may be 'final'	🔶 Warning	55
Lombok @Getter may be used	🔶 Warning	11
@NotNull/@Nullable problems	🔶 Warning	5
Stream API call chain can be simplified	🔶 Warning	5
Non recommended 'field' injections	◽️ Notice	2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 103 dependencies

Third-party software list

This page lists the third-party software dependencies used in bsl-language-server

Dependency	Version	Licenses
aho-corasick-double-array-trie	1.2.2	Apache-2.0
aspectjrt	1.9.22.1	Apache-2.0
checker-qual	3.43.0	MIT
classgraph	4.8.179	MIT
commons-beanutils	1.9.4	Apache-2.0
commons-collections	3.2.2	Apache-2.0
commons-collections4	4.4	Apache-2.0
commons-digester	2.1	Apache-2.0
commons-exec	1.4.0	Apache-2.0
commons-io	2.17.0	Apache-2.0
commons-lang3	3.17.0	Apache-2.0
commons-logging	1.2	Apache-2.0
commons-pool2	2.12.0	Apache-2.0
commons-text	1.10.0	Apache-2.0
commons-validator	1.7	Apache-2.0
error_prone_annotations	2.28.0	Apache-2.0
grpc-netty-shaded	1.66.0	Apache-2.0
gson	2.11.0	Apache-2.0
guava	33.3.1-jre	Apache-2.0
hunspell	2.1.2	Apache-2.0
istack-commons-runtime	4.1.2	BSD-3-Clause
j2objc-annotations	3.0.0	Apache-2.0
jackson-annotations	2.18.2	Apache-2.0
jackson-core	2.18.2	Apache-2.0
jackson-databind	2.18.2	Apache-2.0
jackson-datatype-jdk8	2.18.2	Apache-2.0
jackson-datatype-jsr310	2.18.2	Apache-2.0
jackson-module-parameter-names	2.18.2	Apache-2.0
jakarta.activation-api	2.1.3	BSD-3-Clause
jakarta.annotation-api	2.1.1	Classpath-exception-2.0 EPL-2.0 GPL-2.0-only
jakarta.websocket-api	2.1.1	Classpath-exception-2.0 EPL-2.0 GPL-2.0-only
jakarta.xml.bind-api	4.0.2	BSD-3-Clause
java-diff-utils	4.12	Apache-2.0
java-sarif	2.0	MIT
javax.activation-api	1.2.0	CDDL-1.1 GPL-2.0-only
javax.annotation-api	1.3.2	CDDL-1.0 GPL-2.0-only ORACLE-OPENJDK-EXCEPTION-2.0
jaxb-api	2.3.0	CDDL-1.1 GPL-2.0-only ORACLE-OPENJDK-EXCEPTION-2.0
jaxb-core	4.0.5	BSD-3-Clause
jaxb-runtime	4.0.5	BSD-3-Clause
jgrapht-core	1.5.2	EPL-1.0 LGPL-2.0-or-later
jline-native	3.24.1	BSD-3-Clause
jline-terminal	3.24.1	BSD-3-Clause
jna-platform	5.12.1	Apache-2.0
jna	5.12.1	Apache-2.0
jsr305	3.0.2	Apache-2.0
jul-to-slf4j	2.0.16	MIT
language-detector	0.6	Apache-2.0
language-en	6.5	LGPL-2.0-or-later
language-ru	6.5	LGPL-2.0-or-later
languagetool-core	6.5	LGPL-2.0-or-later
log4j-api	2.24.3	Apache-2.0
log4j-to-slf4j	2.24.3	Apache-2.0
lombok	1.18.36	BSD-3-CLAUSE-NO-TRADEMARK MIT
lucene-backward-codecs	5.5.5	Apache-2.0
lucene-core	5.5.5	Apache-2.0
micrometer-commons	1.14.3	Apache-2.0
micrometer-core	1.14.3	Apache-2.0
micrometer-observation	1.14.3	Apache-2.0
micrometer-registry-prometheus	1.14.3	Apache-2.0
mxparser	1.2.2	xpp
opennlp-chunk-models	1.5	Apache-2.0
opennlp-postag-models	1.5	Apache-2.0
opennlp-tokenize-models	1.5	Apache-2.0
opennlp-tools	1.9.4	Apache-2.0
openregex	1.1.1	LGPL-2.0-or-later
org.abego.treelayout.core	1.0.3	BSD-3-Clause
progressbar	0.10.1	MIT
proto-google-common-protos	2.41.0	Apache-2.0
segment	2.0.1	MIT
simpleclient	0.16.0	Apache-2.0
simpleclient_guava	0.16.0	Apache-2.0
simpleclient_tracer_common	0.16.0	Apache-2.0
simpleclient_tracer_otel	0.16.0	Apache-2.0
simpleclient_tracer_otel_agent	0.16.0	Apache-2.0
slf4j-api	2.0.16	MIT
snakeyaml	2.3	Apache-2.0
spring-aop	6.2.2	Apache-2.0
spring-beans	6.2.2	Apache-2.0
spring-boot-autoconfigure	3.4.2	Apache-2.0
spring-boot-starter-cache	3.4.2	Apache-2.0
spring-boot-starter-json	3.4.2	Apache-2.0
spring-boot-starter-logging	3.4.2	Apache-2.0
spring-boot-starter-tomcat	3.4.2	Apache-2.0
spring-boot-starter-web	3.4.2	Apache-2.0
spring-boot-starter-websocket	3.4.2	Apache-2.0
spring-boot-starter	3.4.2	Apache-2.0
spring-boot	3.4.2	Apache-2.0
spring-context-support	6.2.2	Apache-2.0
spring-context	6.2.2	Apache-2.0
spring-core	6.2.2	Apache-2.0
spring-expression	6.2.2	Apache-2.0
spring-jcl	6.2.2	Apache-2.0
spring-messaging	6.2.2	Apache-2.0
spring-web	6.2.2	Apache-2.0
spring-webmvc	6.2.2	Apache-2.0
spring-websocket	6.2.2	Apache-2.0
st4	4.3.4	BSD-3-Clause
tomcat-embed-core	10.1.34	Apache-2.0 CDDL-1.0 PROPRIETARY-LICENSE
tomcat-embed-el	10.1.34	Apache-2.0
tomcat-embed-websocket	10.1.34	Apache-2.0
txw2	4.0.5	BSD-3-Clause
vavr-match	0.10.2	Apache-2.0
vavr	0.10.2	Apache-2.0

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions