Аппендер вывода логов в LanguageClient, если он подключен #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
github-actions
bot
force-pushed
the
feature/language-client-aware-appender
branch
from
9ddd0a2 to
e9aef17
Compare
Qodana Community for JVM14 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
nixel2007
changed the title
…lient-aware-appender
EightM
reviewed
Jul 27, 2023
| @Override | ||
| protected void writeOut(ILoggingEvent event) throws IOException { | ||
| if (clientHolder != null && clientHolder.isConnected()) { | ||
| var languageClient = clientHolder.getClient().orElseThrow(); |
There was a problem hiding this comment.
фуфу. Говоришь что проверяешь наличие, а сам небезопасно Optional вскрываешь
There was a problem hiding this comment.
isConnected внутри проверяет наличие опшионала :)
Чтобы исключить запуск сервера каждый раз при поднятии спринг-контекста.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes #3069
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно