Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Передача executor service во все сервисы #3105

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

nixel2007
Copy link
Member

@nixel2007 nixel2007 commented Jul 19, 2023

Описание

Добавлена передача cachedThreadPool в методы всех сервисов, использующих supplyAsync. See #3104.

Не уверен насчет дедлоков, но ховер стал отвечать намного-намного быстрее, не дожидаясь конца расчета конфигурации (проверял на УХе)

Связанные задачи

Closes #3104

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

@ghost
Copy link

ghost commented Jul 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

Qodana Community for JVM

14 new problems were found

Inspection name Severity Problems
Statement with empty body 🔶 Warning 5
'@Serial' annotation could be used 🔶 Warning 4
Mismatched query and update of collection 🔶 Warning 2
Mismatched read and write of array 🔶 Warning 1
Nullability and data flow problems 🔶 Warning 1
Redundant character escape 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

8.3% 8.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nixel2007 nixel2007 merged commit 5796c10 into develop Jul 21, 2023
@nixel2007 nixel2007 deleted the feature/async-executor-service branch July 21, 2023 21:58
@nixel2007 nixel2007 added this to the 0.22.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Передача ExecutorService во все CompletableFuture уровня сервисов
1 participant