Возможность запуска анализа всего проекта целиком при открытии #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixel2007
force-pushed
the
feature/analyze-project-on-open
branch
from
28587f0 to
7f90596
Compare
|
SonarCloud Quality Gate failed. |
EightM
reviewed
Dec 1, 2022
src/main/java/com/github/_1c_syntax/bsl/languageserver/AnalyzeProjectOnStart.java
Show resolved
Hide resolved
EightM
reviewed
Dec 1, 2022
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java
Show resolved
Hide resolved
EightM
reviewed
Dec 1, 2022
| } | ||
|
|
||
| states.put(documentContext, State.CREATED); | ||
| documentContext.clearSecondaryData(); |
There was a problem hiding this comment.
Не понимаю. почему после очистки DC он становится Created, а не какой-нибудь Cleared
There was a problem hiding this comment.
думал, нужны ли мне два разных статуса. но так и не придумал зачем. он в любом случае либо с контентом, либо без. может быть CREATED переименовать в WITHOUT_CONTENT?
There was a problem hiding this comment.
WITHOUT_CONTENT больше нравится, да
EightM
reviewed
Dec 1, 2022
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java
Show resolved
Hide resolved
EightM
reviewed
Dec 1, 2022
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java
Show resolved
Hide resolved
EightM
reviewed
Dec 5, 2022
src/main/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContext.java
Outdated
Show resolved
Hide resolved
nixel2007
force-pushed
the
feature/analyze-project-on-open
branch
from
1b47d07 to
0a62232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно