Настройка исключений для диагностики CommentedCodeDiagnostic #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
nixel2007
reviewed
Oct 25, 2022
| @DiagnosticParameter( | ||
| type = String.class | ||
| ) | ||
| private Set<String> exclusionPrefixes = Collections.emptySet(); |
There was a problem hiding this comment.
Т.к. по умолчанию сет пустой, в целом не вижу причин, почему бы не влить не глядя. Но все же спрошу - пробовал замерять с включенной настройкой? не сильно просаживается анализ?
There was a problem hiding this comment.
Сделал замеры
feature/CommentedCodeDiagnostic_exclusionPrefixes
---------------------------------------------- benchmark: 1 tests ---------------------------------------------
Name (time in s) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations
---------------------------------------------------------------------------------------------------------------
test_analyze_ssl31 15.3787 15.9920 15.7355 0.3187 15.8356 0.4600 1;0 0.0636 3 1
---------------------------------------------------------------------------------------------------------------
test_analyze_ssl31 14.8679 15.8270 15.3444 0.4796 15.3382 0.7193 1;0 0.0652 3 1
---------------------------------------------------------------------------------------------------------------
develop
---------------------------------------------- benchmark: 1 tests ---------------------------------------------
Name (time in s) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations
---------------------------------------------------------------------------------------------------------------
test_analyze_ssl31 14.5382 15.2764 14.8924 0.3700 14.8626 0.5537 1;0 0.0671 3 1
---------------------------------------------------------------------------------------------------------------
test_analyze_ssl31 14.8964 16.0918 15.3080 0.6791 14.9359 0.8966 1;0 0.0653 3 1
---------------------------------------------------------------------------------------------------------------
asosnoviy
approved these changes
Oct 26, 2022
theshadowco
deleted the
feature/CommentedCodeDiagnostic_exclusionPrefixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes #2916
Чеклист
Общие
gradlew precommit)Для диагностик
Дополнительно