bump bsl-parser and Disable diagnostics #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Интересно, падает тест |
asosnoviy
force-pushed
the
feature/bsl-parser
branch
5 times, most recently
from
c57b775 to
9e3901a
Compare
asosnoviy
force-pushed
the
feature/bsl-parser
branch
from
9e3901a to
9d60330
Compare
nixel2007
reviewed
Oct 12, 2022
...a/com/github/_1c_syntax/bsl/languageserver/diagnostics/CommonModuleAssignDiagnosticTest.java
Show resolved
Hide resolved
nixel2007
reviewed
Oct 12, 2022
| @@ -81,6 +81,7 @@ public List<BSLDiagnostic> diagnostics(DocumentContext documentContext) { | |||
| .filter(info -> correctModuleType(info, moduleType, fileType)) | |||
| .filter(info -> passedCompatibilityMode(info, compatibilityMode)) | |||
| .map(DiagnosticInfo::getDiagnosticClass) | |||
| .filter(diagnostic -> !diagnostic.isAnnotationPresent(Disabled.class)) | |||
There was a problem hiding this comment.
не стрельнет в случае декоратора? может взять сприновый AnnotationUtils, который проверит иерархию классов?
There was a problem hiding this comment.
Я не справился с AnnotationUtils
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@disable для диагностик
Поднятие версии парсера
Выключение диагностики FieldsFromJoinsWithoutIsNull