-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Отправка исключений в Sentry #2794
Conversation
SonarCloud Quality Gate failed. |
0f16ec3
to
1929d56
Compare
1929d56
to
a4722ec
Compare
e9db8d3
to
60bf09d
Compare
SonarCloud Quality Gate failed. |
https://sentry.io/organizations/1c-syntax/projects/bsl-language-server | ||
|
||
К сожалению, особенности настройки доступа к Sentry.io ограничивают возможность просмотра данных | ||
неавторизованным пользователям. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Проверил ссылку, я авторизован через гитхаб, но указанный проект не вижу
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
возможно, права на проект в Сентри есть только у мейнтейнеров бсл лс?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
получил ошибку Authentication error: You do not have access to the required GitHub organization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Да, проект виден только участникам 1c-syntax.
Отсутствие ответа воспринимается как "не отправлять эту ошибку, но спросить снова". | ||
|
||
Сообщение об ошибке не содержит идентификационных данных пользователя или рабочей станции | ||
за исключением генерируемого UUID сессии для связывания ошибок, возникающих в течении одного |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
запятая перед "за исключением"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я вот не уверен....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
используй синоним "кроме". а перед ним запятая точно обязательна!
docs/features/Monitoring.md
Outdated
|
||
Если вы включите отладочные логи (настроив `logback` или используя переменные среды), содержимое логов (последние 100 записей) приложится к отправляемому событию. | ||
|
||
Некоторые сообщения, пересылаемые между Language Client и BSL Language Server содержат фрагменты исходного кода |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
запятая перед содержат
|
||
Пример отправляемого события об ошибке: | ||
|
||
??? event.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
что за "???"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoiler в mkdocs
"type": "RuntimeException", | ||
"value": "psss", | ||
"module": "java.lang", | ||
"stacktrace": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
стек-трейс в обратном порядке выдается или нет?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не знаю. А какая разница? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тогда остается убедиться, что ты в сентри стек-трейс смотрел.
там в каком виде выдается?
ошибка сверху или нет? )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В сентри оно выглядит как обычно - от глубокого к верхнему. Плюс этот файл генерит sentry sdk, а не я, они, думаю, знают в каком виде слать себе эксепшены :)
map.put(Resources.getResourceString(language, clazz, "answer_sendOnce"), SendErrorsMode.SEND_ONCE); | ||
map.put(Resources.getResourceString(language, clazz, "answer_skip"), SendErrorsMode.ASK); | ||
map.put(Resources.getResourceString(language, clazz, "answer_send"), SendErrorsMode.SEND); | ||
map.put(Resources.getResourceString(language, clazz, "answer_dontSend"), SendErrorsMode.NEVER); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А почему ИД ресурсов не в константах?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Было лень :)
@NoArgsConstructor | ||
public class SentryAspect { | ||
|
||
private final ExecutorService executorService = Executors.newCachedThreadPool(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Забыл закрыть
Описание
Отправка уведомлений об ошибках в Sentry. Три режима отправки:
Четыре возможных ответа на вопрос:
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit
)Для диагностик
Дополнительно