-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Правило Повторное добавление\вставка значений в коллекцию - DuplicatedInsertionIntoCollectionDiagnostic - ГОТОВО #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
а не простой переменной
рефакторинг имен
шапка файлов замечания стат.анализа
ускорил\улучшил проверку передачи частей ключа
также исключаются дубли имен из методов
убрал невыполнимые условия улучшено покрытие упрощены утверждения
используются в новой диагностике
Kudos, SonarCloud Quality Gate passed! |
theshadowco
approved these changes
Jun 9, 2022
@theshadowco не совсем понял, ты аппрувишь или еще раз посмотришь? |
@theshadowco @nixel2007 правило готово. примите его, если нет возражений. |
artbear
changed the title
Правило Повторное добавление\вставка значений в коллекцию - DuplicatedInsertionIntoCollectionDiagnostic
Правило Повторное добавление\вставка значений в коллекцию - DuplicatedInsertionIntoCollectionDiagnostic - ГОТОВО
Sep 25, 2022
theshadowco
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes #1551
Чеклист
Общие
gradlew precommit
)Для диагностик
Дополнительно