Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DigitSymbol separator requires both #39

Open
wants to merge 16 commits into
base: release/v0.2.0
Choose a base branch
from

Conversation

jpgoldberg
Copy link
Contributor

@jpgoldberg jpgoldberg commented Jun 2, 2019

Resolves #15

The external changes are that

  1. A new pre-baked separator function, SFDigitsAndSymbols requires that at least one digit and at least one symbol appear as separators somewhere. Note that setting this for a pwd with only one separator will fail.

  2. The two character separators are no more. (We will be able to bring them back, but it will take some work). I do not believe that anyone was using them or that we exposed those in any UI

  3. This exports some new stuff (which needs to be reviewed)

In order to do (1), which is what the issue called for, I needed to change how the separator functions work and how they are used during password generation. So there is a lot of new code in here. This does look a bit ahead to other things which we would like to do with separators.

Note that I will be traveling a great deal over the summer and my availability is limited.

Concerns before merging

  • Tests of constant separators
  • Tests of proper entropy calculation when using the new separator functions
  • Review of what should and shouldn't be exported
  • Are there better ways to make use of the function type definitions to clean up code.

@jpgoldberg jpgoldberg requested review from robyoder and mitchchn June 2, 2019 23:09
@jpgoldberg jpgoldberg changed the base branch from master to release/v0.2.0 January 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a separator function for digits and safe symbols
1 participant