-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DigitSymbol separator requires both #39
Open
jpgoldberg
wants to merge
16
commits into
release/v0.2.0
Choose a base branch
from
jpg/sep-func-15
base: release/v0.2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+245
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But more tests needed
SFDigitsAndSymbols is the new name for the separator functions that requires both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15
The external changes are that
A new pre-baked separator function,
SFDigitsAndSymbols
requires that at least one digit and at least one symbol appear as separators somewhere. Note that setting this for a pwd with only one separator will fail.The two character separators are no more. (We will be able to bring them back, but it will take some work). I do not believe that anyone was using them or that we exposed those in any UI
This exports some new stuff (which needs to be reviewed)
In order to do (1), which is what the issue called for, I needed to change how the separator functions work and how they are used during password generation. So there is a lot of new code in here. This does look a bit ahead to other things which we would like to do with separators.
Note that I will be traveling a great deal over the summer and my availability is limited.
Concerns before merging