Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify secrets and FromEnv in addition to Env #74

Merged
merged 2 commits into from
Feb 18, 2022
Merged

Verify secrets and FromEnv in addition to Env #74

merged 2 commits into from
Feb 18, 2022

Conversation

samifruit514
Copy link

@samifruit514 samifruit514 commented Sep 24, 2021 •
edited
Loading

fixes #73

@samifruit514 samifruit514 mentioned this pull request Sep 24, 2021
Closed
@slok
Copy link
Contributor

slok commented Oct 26, 2021

Hi all!

Any news with this PR? we are looking forward seeing this released :)

Thanks!

@slok
Copy link
Contributor

slok commented Jan 10, 2022

👋 Hello again! Is there something we could do from our side to push this forward?

Thanks!

cc/ @jillianwilson

@Marton6 Marton6 mentioned this pull request Feb 18, 2022
Closed
@SimonBarendse SimonBarendse requested review from SimonBarendse and Marton6 and removed request for jillianwilson February 18, 2022 18:36
SimonBarendse
SimonBarendse approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@SimonBarendse SimonBarendse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samifruit514 ! ❤️

Marton6
Marton6 approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@Marton6 Marton6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@Marton6 Marton6 closed this Feb 18, 2022
@Marton6 Marton6 reopened this Feb 18, 2022
@Marton6 Marton6 merged commit b1e251d into 1Password:main Feb 18, 2022
@github-actions github-actions bot mentioned this pull request Feb 21, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBarendse SimonBarendse SimonBarendse approved these changes

@Marton6 Marton6 Marton6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1password-operator does not support .envFrom
4 participants
@samifruit514 @slok @SimonBarendse @Marton6