Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: application workflow node params #2087

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: application workflow node params #2087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ui/src/workflow/common/NodeCascader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,9 @@ const validate = () => {
props.nodeModel.graphModel.eventCenter.on('refresh_incoming_node_field', () => {
options.value = getIncomingNode(props.nodeModel.id)
})
props.nodeModel.graphModel.eventCenter.on('refreshFileUploadConfig', () => {
options.value = getIncomingNode(props.nodeModel.id)
})
defineExpose({ validate })
onMounted(() => {
options.value = getIncomingNode(props.nodeModel.id)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet is almost correct, but there are a couple of improvements that could be made:

  1. The validate function should return true to indicate successful validation if needed.

  2. A comment explaining why the event listener for 'refreshFileUploadConfig' is added might help improve readability.

Here's the revised code with these suggestions:

const validate = () => {
  // Implement any necessary logic here for validating node data
  // Return true to indicate successful validation if applicable
}

const { options } = useOptions()

props.nodeModel.graphModel.eventCenter.on('refresh_incoming_node_field', () => {
  options.value = getIncomingNode(props.nodeModel.id)
})

// Event listener for refreshing file upload configurations (optional comment)
props.nodeModel.graphModel.eventCenter.on('refreshFileUploadConfig', () => {
  options.value = getIncomingNode(props.nodeModel.id)
})

defineExpose({
  validate
})

onMounted(() => {
  options.value = getIncomingNode(props.nodeModel.id)
}

Additional optimizations:

  • Ensure that the getIncomingNode function is properly implemented and returns the expected data structure.

  • If you're using Vue components, consider wrapping this逻辑 within hooks or computed properties to keep it organized.

Make sure all dependencies (useOptions, prop, etc.) are correctly imported or defined in your context.

Expand Down
Loading