Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tip image 404 #1966

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: tip image 404 #1966

merged 1 commit into from
Jan 2, 2025

Conversation

shaohuzhang1
Copy link
Contributor

fix: tip image 404

Copy link

f2c-ci-robot bot commented Jan 2, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

f2c-ci-robot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -418,7 +418,7 @@ const startRecording = async () => {
2、若无 https 配置则需要修改浏览器安全配置,Chrome 设置如下:<br/>
(1) 地址栏输入chrome://flags/#unsafely-treat-insecure-origin-as-secure;<br/>
(2) 将 http 站点配置在文本框中,例如: http://127.0.0.1:8080。</p>
<img src="${new URL(`../../assets/tipIMG.jpg`, import.meta.url).href}" style="width: 100%;" />`,
<img src="${new URL(`@/assets/tipIMG.jpg`, import.meta.url).href}" style="width: 100%;" />`,
{
confirmButtonText: '我知道了',
dangerouslyUseHTMLString: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to have a couple of small issues:

  1. In the error message string, there is an extra space after "Tip":
    Correct format:

    `2、若无 https 配置则需要修改浏览器安全配置,Chrome 设置如下:<br/>
        (1) 地址栏输入 chrome://flags/#unsafely-treat-insecure-origin-as-secure;<br/>
        (2) 将 http 站点配置在文本框中,例如: http://127.0.0.1:8080。`
    
  2. The image source paths in both instances (../../assets/tipIMG.jpg and @/assets/tipIMG.jpg) look correct.

Otherwise, everything looks good with no other obvious errors or potential issues.

@wangdan-fit2cloud wangdan-fit2cloud merged commit 8928783 into main Jan 2, 2025
4 checks passed
@wangdan-fit2cloud wangdan-fit2cloud deleted the pr@main@fix-bugs branch January 2, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants