fix: Fix the issue of frontend packaging errors #7661
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -83,7 +83,7 @@ export default defineConfig(({ mode }: ConfigEnv): UserConfig => { | |||
| }), | |||
| ], | |||
| esbuild: { | |||
| pure: viteEnv.VITE_DROP_CONSOLE ? ['console.log', 'debugger'] : [], | |||
| pure: viteEnv.VITE_DROP_CONSOLE ? ['console.log'] : [], | |||
| }, | |||
| build: { | |||
| outDir: '../cmd/server/web', | |||
There was a problem hiding this comment.
The changes are minor:
- The
esbuild.pureoption is adjusted to exclude both'console.log'and'debugger', but only'console.log'will be excluded now.
Optimization suggestions:
- If you want to completely remove everything printed in the console (not just logs), consider using
process.env.NODE_ENV === 'production'instead of checking for environment variables directly. - Ensure that other parts of your codebase don't print things unexpectedly if they expect the original behavior.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No description provided.