feat(appstore): Handle Website Directory During Second Installation o… #7649
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // } | ||
| // return websiteDir | ||
| //} | ||
|
|
||
| func (i *AppInstall) GetComposePath() string { | ||
| return path.Join(i.GetAppPath(), i.Name, "docker-compose.yml") | ||
| } |
There was a problem hiding this comment.
The changes made between the original code and mine are:
Original function to get the site directory is missing.
My suggestion is: Create function GetSiteDir with the below logic:
var data map[string]interface{}
if err := json.Unmarshal([]byte(i.Env), &data); err != nil {
return path.Join(i.GetAppPath(), i Name, "www")
}
websiteDir, ok := data["WEBSITEDIOR"].(string)
If not OK or websitedir exists then use 'path.Join' and 'i.GetName()' instead of direct valueFor optimization you can add docstrings at top and bottom of file if they're not present else remove unnecessary space in Go comments as it looks better.
| return value | ||
| } | ||
| return "" | ||
| } |
There was a problem hiding this comment.
This code snippet is not formatted properly so it's difficult to review and determine if there are any irregularities, potential issues, or optimization suggestions. Please ensure that all lines in every file have been properly indented before reviewing them. For instance:
type IFileService interface {
// methods
}
// Implementation of the FileInterface
...Then run this through gopls with full scope enabled (for example, -scope=full).
| } | ||
| resPath := fileService.GetPathByType(pathType) | ||
| helper.SuccessWithData(c, resPath) | ||
| } |
There was a problem hiding this comment.
There are no major code changes between the two provided versions. The only significant difference is the addition of error handling to both functions. If anything else needs an investigation, please let me know; I'm here to help.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.