Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid postion of before content in home page #7429

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

JohnNiang
Copy link
Contributor

What this PR does / why we need it?

When I open 1Panel in Firefox on Linux(133.0.3) and Chrome(131.0.6778.139), all before contents of headers in home page are born in a wrong position. Please see the screenshot below:

image

image

This PR fixes the problem completely. See the screenshots below:

image

image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.
None

Copy link

f2c-ci-robot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit 063a071 into 1Panel-dev:dev Dec 18, 2024
1 of 4 checks passed
@JohnNiang JohnNiang deleted the bug/home-page-ui-style branch December 18, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants