Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 解决更新端口不更新防火墙规则的问题 #7169

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: 解决更新端口不更新防火墙规则的问题 #7169

merged 1 commit into from
Nov 25, 2024

Conversation

igophper
Copy link
Contributor

Refs #7164

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 24, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud
Copy link
Member

感谢支持。

@igophper igophper force-pushed the pr@dev@fix_cmd_update_port branch from 718fa9b to e2470f0 Compare November 25, 2024 05:47
ssongliu
ssongliu reviewed Nov 25, 2024
View reviewed changes
cmd/server/cmd/update.go Outdated Show resolved Hide resolved
@igophper igophper force-pushed the pr@dev@fix_cmd_update_port branch from e2470f0 to 18be48b Compare November 25, 2024 06:44
@igophper igophper marked this pull request as draft November 25, 2024 06:46
@igophper igophper force-pushed the pr@dev@fix_cmd_update_port branch from 18be48b to 76aa3f1 Compare November 25, 2024 06:47
@igophper igophper marked this pull request as ready for review November 25, 2024 06:47
@ssongliu
Copy link
Member

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Nov 25, 2024
@wanghe-fit2cloud wanghe-fit2cloud merged commit 7dc0a2f into 1Panel-dev:dev Nov 25, 2024
1 of 4 checks passed
@igophper igophper deleted the pr@dev@fix_cmd_update_port branch November 25, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghe-fit2cloud wanghe-fit2cloud Awaiting requested review from wanghe-fit2cloud

@ssongliu ssongliu Awaiting requested review from ssongliu

@zhengkunwang223 zhengkunwang223 Awaiting requested review from zhengkunwang223

Assignees

@ssongliu ssongliu

Labels
do-not-merge/release-note-label-needed lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igophper @wanghe-fit2cloud @ssongliu