Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_response_jwt crashes when deep_link_settings['data'] is not set #63

Open
etsikt opened this issue Nov 2, 2021 · 2 comments
Open

Comments

@etsikt
Copy link

etsikt commented Nov 2, 2021

Steps to reproduce:

  1. Issue a deep linking request message without specifying deep_link_settings['data'].
  2. Respond using output_response_form function in LTI_Deep_Link.php
  3. Notice that the code crashes because deep_link_settings['data'] is not set:
    [2021-11-02 15:26:50] production.ERROR: Undefined index: data {"exception":"[object] (ErrorException(code: 0): Undefined index: data at /var/www/vendor/imsglobal/lti-1p3-tool/src/lti/LTI_Deep_Link.php:28)
    Link to GitHUB: https://github.com/IMSGlobal/lti-1-3-php-library/blob/3a192de99f3783d76caea462b0d04db28569c123/src/lti/LTI_Deep_Link.php#L28

Expected behaviour:
According to https://www.imsglobal.org/spec/lti-dl/v2p0#deep-linking-settings data is not
a required value, and the code should therefore check whether it is set or not and handle both situations.

@sunny047
Copy link

sunny047 commented Feb 9, 2022

Hi,

Any update on this issue? I am testing this library in a laravel and facing this issue while using the output_response_form function.

@etsikt
Copy link
Author

etsikt commented Feb 10, 2022

I ended up doing a fork with these changes: matematikk-mooc@eb6a4fb

JanHolger pushed a commit to JanHolger/lti-1-3-php-library that referenced this issue Jul 26, 2022
PODB-603: Update error message for missing registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants