Switch to Nodes implementation #1
Conversation
There is no reason to have a different implementation in this module than Node. Since that's what it says to be, an "Outsource of Node's internal FreeList module". - package.json: changed to MIT license, that's what Node has. - assert function was unused - unnecessary arguments to Array: http://stackoverflow.com/a/20375156 - There was a check for undefined constructor. But seriously, who wants a free list of plain Objects? - Added last line in new version to keep shorthand without ".FreeList"
|
Although I understand and welcome your effort, I don't see the point. This module doesn't carry the MIT license, because it's in fact the pretty-printed compilation of what we deployed in production: freelist.coffee, not the FreeList module that Node carries. That is, I'm happy you highlighted the superfluent assertion! I'd be willing to land and maintain your proposal if you could outline actual functional differences or deficiencies in the published version. Cheers REL nodejs/node#569 |
|
I'm afraid I don't know any functional differences, so I'll close this :) I think it's easier for you to remove the assert function yourself, instead of me creating a new pull request. You'd anyway need to checkout the code, to do There were just some things like the assert or that the README is missing on npm (it was added after the last Relating to nodejs/node#569: The reason I'm interested in FreeList is because I want to make a package of Nodes http, for platforms where you have TCP Socket APIs as in Chrome Apps. |
|
Landed at 7bbe7f0 as [email protected]. Thanks! |
|
Did you now intentionally change the license to MIT? |
|
Yes :-) I'm just against carrying Joyent in everything node-ish. Cheers |
There is no reason to have a different implementation/code in this module than Node. Since that's what it says to be, an "Outsource of Node's internal FreeList module".
.FreeListI already updated the version, you simply have to
npm publishyet.