Extract Stylelint configuration for publish to NPM #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: So that we can use the same configuration across our projects (e.g. 18f/identity-style-guide).
mitchellhenke
approved these changes
Dec 8, 2021
|
When testing this out in |
**Why**: So that it's easier to act on an error
Not used, only using its dependency "recommended"
|
I gave it a shot in d4a0219. Was quite straight-forward, with the main differences being:
Let me know if you have any concerns @mitchellhenke , but I'm feeling quite good about it. |
|
Looks good to me! 👍🏼 |
**Why**: Because they sometimes can't coexist
aduth
added a commit
to 18F/identity-design-system
that referenced
this pull request
Dec 9, 2021
Related: 18F/identity-idp#5689 **Why:** So that we can use a common standard ruleset across all repositories where Sass is used.
aduth
added a commit
to 18F/identity-design-system
that referenced
this pull request
Dec 9, 2021
Related: 18F/identity-idp#5689 **Why:** So that we can use a common standard ruleset across all repositories where Sass is used.
aduth
added a commit
to 18F/identity-design-system
that referenced
this pull request
Dec 9, 2021
* Use login.gov shared Stylelint configuration Related: 18F/identity-idp#5689 **Why:** So that we can use a common standard ruleset across all repositories where Sass is used. * Fix dependency resolution for stylelint-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So that we can use the same configuration across our projects (e.g. 18f/identity-style-guide).