LG-5072: Add Start Over to additional steps in the IAL2 flow #5394
Conversation
There was a problem hiding this comment.
Looks good to me - two questions to confirm:
- Does/should the "Start over" button appear on the variation of the "Re-enter your password" screen that is in the verify by mail flow as well? I think that's the only page in the mail flow where it might make sense.
- Accessibility: Can you double-check for me that Start Over is focusable and appears in the tab order, if you haven't already?
If those things are good, then all good on my end. Thanks!
|
Thanks for looking @anniehirshman-gsa . As a general answer to both your questions, we're reusing a lot of existing implementation, so it should behave much the same as other screens.
start-over-focusable.mov |
**Why**: Because not all "Start Over" occurs is expected to occur within the FlowStateMachine (e.g. GPO verification, soon others).
**Why**: Because sometimes events are logged without any attributes, and it's tedious / redundant to have to explicitly pass an empty hash, especially when the original call under test doesn't actually have to pass an empty hash.
aduth
force-pushed
the
aduth-lg-5072-start-over
branch
from
742ea91 to
911aefc
Compare
Separate from this work, one thing which has stood out to me about our unstyled buttons is that the custom focus styles appear differently than they do for a link, which is rather noticeable when otherwise the visual appearance is mostly the same. I wonder if we ought to align them? You can see in the above video when tabbing from "Start Over" (an unstyled button) to "Cancel" (a link). |
start_over_or_cancel uses cancel shared partial, which relies on specific values to determine whether user is signing up
Yes, I was thinking the same thing! Lmk if there is a good opportunity to fold in that improvement, or if it makes more sense to ticket separately (happy to do that). |
I'd see it as something we could do from the design system. I can follow-up to track it. |
|
Pulling out discussion from https://github.com/18F/identity-idp/pull/5394/files#r708574782, a couple revisions based on further discussion with @amathews-fs : |
It passes as-is
All passing
**Why**: It's already there!
* Repurpose Idv::SessionsController#destroy for IAL2 restart **Why**: Because not all "Start Over" occurs is expected to occur within the FlowStateMachine (e.g. GPO verification, soon others). * Add "Start Over" link to IAL2 steps * Allow have_logged_event with absent attributes **Why**: Because sometimes events are logged without any attributes, and it's tedious / redundant to have to explicitly pass an empty hash, especially when the original call under test doesn't actually have to pass an empty hash. * Add Idv::SessionsController spec * Mock missing view values for IdV phone start_over_or_cancel uses cancel shared partial, which relies on specific values to determine whether user is signing up * Mock missing view values for IdV OTP delivery method * Support logging location params for SessionsController#destroy * Log "clear and start over" via step, location params * Opt-in verify_account view for ERB linting * Remove unused analytics constant * Remove unnecessary ERBLint exclusion It passes as-is * Remove more unnecessary ERBLint exclusions All passing * Add trailing comma to _start_over_or_cancel ERBLint * Pass step to start over link **Why**: It's already there!
Why: As an end user, I want an option to start over the identity verification process (IAL2), so that I can try to verify my identity again if I do not want to abandon the process completely.
Pending: Improve spec coverage, possible spec fixes needed.
Screenshots: