Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-1344 Fix account reset for users with 1 MFA (ie no personal key) #2981

Merged
merged 2 commits into from
May 30, 2019

Conversation

stevegsa
Copy link
Contributor

@stevegsa stevegsa commented May 30, 2019

Users are using their personal key to sign in, getting routed to setup a 2nd mfa, then abandoning it. They come back later, and if they’ve lost their 1st mfa they can’t delete account because it’s checking to see that they completed registration (ie 2 mfas - personal key and phone). this used to not be an issue because when they’d sign in with personal key before they’d immediately get a new one (ie always have 2 mfas).

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated
    as the first callback.

Database

  • Unsafe migrations are implemented over several PRs and over several
    deploys to avoid production errors. The strong_migrations gem
    will warn you about unsafe migrations and has great step-by-step instructions
    for various scenarios.

  • Indexes were added if necessary. This article provides a good overview
    of indexes in Rails.

  • Verified that the changes don't affect other apps (such as the dashboard)

  • When relevant, a rake task is created to populate the necessary DB columns
    in the various environments right before deploying, taking into account the users
    who might not have interacted with this column yet (such as users who have not
    set a password yet)

  • Migrations against existing tables have been tested against a copy of the
    production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
    issues. In that case, all the migration did was add a new column and an index to
    the Users table, which might seem innocuous.

  • When fetching a single record from the database, #take is used instead
    of #first unless there is an #order call on the ActiveRecord relations.
    This prevents ActiveRecord from sorting by primary key which can result in slow
    queries.

Encryption

  • The changes are compatible with data that was encrypted with the old code.

Routes

  • GET requests are not vulnerable to CSRF attacks (i.e. they don't change
    state or result in destructive behavior).

Session

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

Testing

  • Tests added for this feature/bug
  • Prefer feature/integration specs over controller specs
  • When adding code that reads data, write tests for nil values, empty strings,
    and invalid inputs.

@stevegsa stevegsa marked this pull request as ready for review May 30, 2019 16:21
@stevegsa stevegsa changed the title Fix account reset for users with 1 MFA (ie no personal key) LG-1344 Fix account reset for users with 1 MFA (ie no personal key) May 30, 2019
@stevegsa stevegsa merged commit 229237f into master May 30, 2019
@amathews-fs amathews-fs deleted the stevegsa-fix-account-reset-for-1-mfa branch January 7, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants