-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-935 Push notifications for account delete events #2950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevegsa
force-pushed
the
stevegsa-push-notifications
branch
from
May 15, 2019 04:45
dc48193
to
d4bdcaa
Compare
jmhooper
reviewed
May 16, 2019
jmhooper
reviewed
May 16, 2019
jmhooper
reviewed
May 16, 2019
jmhooper
reviewed
May 16, 2019
jmhooper
reviewed
May 16, 2019
jmhooper
reviewed
May 16, 2019
stevegsa
force-pushed
the
stevegsa-push-notifications
branch
from
May 17, 2019 02:27
9a6a06e
to
da7e532
Compare
jmhooper
previously approved these changes
May 17, 2019
**Why**: So agencies can be notified of delete account events on a push basis to make better access decisions for their applications. **How**: Implement a mixture of the web push protocol combined with our existing OIDC protocol and certs.
…ebPush, headers to push_notification_headers
stevegsa
force-pushed
the
stevegsa-push-notifications
branch
from
May 17, 2019 20:11
a620eb7
to
038054d
Compare
jmhooper
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So agencies can be notified of delete account events on a push basis to make better access decisions for their applications.
How: Implement a mixture of the web push protocol combined with our existing OIDC protocol and certs.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticated
as the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
When fetching a single record from the database,
#take
is used insteadof
#first
unless there is an#order
call on the ActiveRecord relations.This prevents ActiveRecord from sorting by primary key which can result in slow
queries.
Encryption
Routes
state or result in destructive behavior).
Session
user_session
helperinstead of the
session
helper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.