Use a service class to send confirmation emails #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Because when the confirmation logic is moved out of the user model into the email address model having the user handling sending the notification won't make sense anymore.
jmhooper
commented
May 15, 2019
| # :reek:DuplicateMethodCall | ||
| def email_address | ||
| @email_address ||= begin | ||
| raise handle_multiple_email_address_error if user.email_addresses.count > 1 |
There was a problem hiding this comment.
The raise here is redundant
jmhooper
commented
May 15, 2019
| subject.call(request_id: request_id, instructions: instructions) | ||
| end | ||
|
|
||
| it 'creates updates the confirmation values on the email address for the user' do |
There was a problem hiding this comment.
Need to get rid of creates here
achapm
reviewed
May 16, 2019
| @@ -9,6 +9,19 @@ def email_changed(old_email) | |||
| mail(to: old_email, subject: t('mailer.email_change_notice.subject')) | |||
| end | |||
|
|
|||
| # :reek:ControlParameter | |||
| # :reek:LongParameterList | |||
| # :reek:TooManyStatements | |||
There was a problem hiding this comment.
I assume you want to leave in the 3 lines above. I am pointing this out in case you intended to remove them later.
There was a problem hiding this comment.
Yes, I meant to disable these. Normally I'd add a method for consuming the parameters, but this class is already pretty fat and I'd be worried about that getting lost in the concerns it has for the other mails it sends.
achapm
previously approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Because when the confirmation logic is moved out of the user model into the email address model having the user handling sending the notification won't make sense anymore.