Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin.move.mil to production service providers #2910

Merged
merged 3 commits into from
May 3, 2019

Conversation

chrisgilmerproj
Copy link

Adding a new production service provider for the subdomain https://admin.move.mil for MilMove. I've also sorted all of the MilMove domains to be near each other in the file. We need this available before we merge transcom/mymove#1980 to production. The Identity Sandbox has already been updated.

cc @reggieriser

@amoose
Copy link
Contributor

amoose commented May 1, 2019

Hey Chris! Thanks for providing this! We just need two things in order to get this merged in:

  1. Please confirm that the changes included in this PR are correct and valid.
    • This new entry will use the same public cert/key as your other apps.
    • There is no logout URI registered.
  2. Please confirm the estimated user count in order to keep the current IAA compliant.

Please send this in an email to [email protected] and we will get this merged. If merged by 5/3, it will be available in production on 5/9.

@chrisgilmerproj
Copy link
Author

@amoose - Thanks for helping us with this! Here are my answers to your questions above:

  1. The changes look correct to me. I'm fine with reusing the cert/key as in the other apps. I'm also pretty certain we meant to not have a logout URI but if you think that's a problem I can do some research and submit another PR.

  2. Could you link me to the IAA docs? I can only guess at our user count which I think is in the 100-200 range. That includes our staff and the several pilot programs we've run. I don't expect we'll be seeing the 1000-2000 range until this summer.

I'll email this information to [email protected] as well.

@amoose amoose merged commit 08984cc into 18F:master May 3, 2019
@chrisgilmerproj
Copy link
Author

@amoose - Thanks for all your help with this!

@chrisgilmerproj chrisgilmerproj deleted the cg_admin_move_mil branch May 3, 2019 17:59
@reggieriser
Copy link

@amoose Just double-checking -- is this PR in production now? I'm about to merge some code on our side that will reference it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants