Use 18f logo for service provider session decorator test #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Using a logo that does not exist causes the asset pipeline to fallback to a file that may or may not be in the public directory. This behavior is deprecated and will cause us problems if we keep it around. This commit uses a logo that exists and matches against a slightly more complicated path to work around this deprecation issue.
jgsmith-usds
approved these changes
Mar 18, 2019
cpbgsa
pushed a commit
that referenced
this pull request
Mar 22, 2019
**Why**: Using a logo that does not exist causes the asset pipeline to fallback to a file that may or may not be in the public directory. This behavior is deprecated and will cause us problems if we keep it around. This commit uses a logo that exists and matches against a slightly more complicated path to work around this deprecation issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Using a logo that does not exist causes the asset pipeline to fallback to a file that may or may not be in the public directory. This behavior is deprecated and will cause us problems if we keep it around.