Disable bullet in unit tests #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Bullet will auto-detect attributes that are eager loaded but not used. In unit tests that eager load things, but don't use them right away, this causes issues. This commit disables bullet in unit tests so it will only run in feature tests where slow queries are more accurately identified.
paolov18F
approved these changes
Mar 18, 2019
cpbgsa
pushed a commit
that referenced
this pull request
Mar 22, 2019
**Why**: Bullet will auto-detect attributes that are eager loaded but not used. In unit tests that eager load things, but don't use them right away, this causes issues. This commit disables bullet in unit tests so it will only run in feature tests where slow queries are more accurately identified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Bullet will auto-detect attributes that are eager loaded but not used. In unit tests that eager load things, but don't use them right away, this causes issues. This commit disables bullet in unit tests so it will only run in feature tests where slow queries are more accurately identified.