LG-882 Invalid physical mail address

[stevegsa]

Why: So users can still be verified even after their US postal address is found to be undeliverable.

How: Introduce a new state to the usps screen for sending a letter. This state will be the condition where the letter sent was undeliverable. Add a method to the user decorater which digs into the usps_confirmation_codes for the user's profiles to see if the code was marked by the async undeliverable address notifier process. In that condition the user will receive an email notifying them to sign in to login.gov. When they sign in to login.gov rather than seeing a notification that tells them to enter their code they will see a message telling them their mail was undeliverable and to send a new letter they will need to update their address on file.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated
  as the first callback.

Database

• Unsafe migrations are implemented over several PRs and over several
  deploys to avoid production errors. The strong_migrations gem
  will warn you about unsafe migrations and has great step-by-step instructions
  for various scenarios.

• Indexes were added if necessary. This article provides a good overview
  of indexes in Rails.

• Verified that the changes don't affect other apps (such as the dashboard)

• When relevant, a rake task is created to populate the necessary DB columns
  in the various environments right before deploying, taking into account the users
  who might not have interacted with this column yet (such as users who have not
  set a password yet)

• Migrations against existing tables have been tested against a copy of the
  production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
  issues. In that case, all the migration did was add a new column and an index to
  the Users table, which might seem innocuous.

Encryption

• The changes are compatible with data that was encrypted with the old code.

Routes

• GET requests are not vulnerable to CSRF attacks (i.e. they don't change
  state or result in destructive behavior).

Session

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

Testing

• Tests added for this feature/bug
• Prefer feature/integration specs over controller specs
• When adding code that reads data, write tests for nil values, empty strings,
  and invalid inputs.

[stevegsa]

Screenshots:

---

---

---

---

---

---

---

---

---

---

---

[nickttng]

@stevegsa Two screens for copy updates (see screen images below) for consistency. Let me know if it's not clear

• When stating "letter," it is the default phrasing referring to the object itself
• When stating "mail," use as a verb/action only in this case, i.g. "It will be mailed", "They will mail", not as an object, e.g. "Your mail is on its way"

Note: I'm looking at any inconsistency between 'deliver' vs. 'mail'

[cpbgsa]

Need to add proper translations for the French and Spanish messages.

[jmhooper]

We also definitely need some feature level tests for this.

[stevegsa]

Thanks for the feedback. The screenshots have been updated for your review. Working on finishing the code/functionality and specs now.

[jmhooper]

This controller has gotten to almost 160 lines, which to me looks like a signal that some of this should be moved into a service

[jmhooper]

This diff is pretty heavy. I think including changes like this, which aren't totally necessary for the change on the table in a separate PR would help slim things down and make this easier to review in the future.

[stevegsa]

You said you would not approve it without the throttling.