Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scaffolding to migrate to 2L-KMS #2760

Merged
merged 6 commits into from
Mar 5, 2019

Conversation

jmhooper
Copy link
Member

Why: When the 2L-KMS migration is completed, these feature flags
will no longer be necessary since they will always be on.

@jmhooper
Copy link
Member Author

This should not be merged until #2734 and #2735 have been deployed and the rake task to add the context to all profiles has been completed.

@jmhooper jmhooper force-pushed the jmhooper-remove-2l-kms-scaffolding branch from 6b970b6 to a4910a3 Compare February 19, 2019 20:19
**Why**: When the 2L-KMS migration is completed, these feature flags
will no longer be necessary since they will always be on.
@jmhooper jmhooper force-pushed the jmhooper-remove-2l-kms-scaffolding branch 2 times, most recently from 1fc109a to 8ea9955 Compare February 19, 2019 20:30
stevegsa
stevegsa previously approved these changes Feb 21, 2019
Copy link
Contributor

@stevegsa stevegsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmhooper jmhooper merged commit 0c7e52d into master Mar 5, 2019
@amathews-fs amathews-fs deleted the jmhooper-remove-2l-kms-scaffolding branch January 7, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants