-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-538 New Document Authentication Design #2741
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screenshots:Desktop only flow:User selects "Use your computer"Mobile only flow:User selects "Use your phone"(user scrolls the screen)Desktop to phone flow:user selects "Use your phone"text message:Mobile to desktop flow:User chooses "Use your computer"Email message sent to desktop computer: |
**Why**: So our users can verify their identity on mobile phones with a camera or desktop computers with a scanned image. **How**: Detect whether a user is one a mobile phone or a desktop. Add new flows to accomodate desktop computers, mobile phones, desktop computers to mobile phones (ie user wants to use their camera), and mobile phones to desktop computers (ie user has a scanner). Add image previews on document uploads. Supply different verbiage for taking a picture vs. uploading an image.
stevegsa
force-pushed
the
stevegsa-new-doc-auth-design
branch
from
February 11, 2019 05:42
3bc5077
to
43e7e27
Compare
jgsmith-usds
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay. We can polish in the next release if we need to.
@stevegsa Latest iteration in InVision - DocAuth v5b if you want to peek. Meanwhile, I'm checking with @erinzstrenio about any content edit needed. |
@nickttng the design looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: So our users can verify their identity on mobile phones with a camera or desktop computers with a scanned image.
How: Detect whether a user is on a mobile phone or a laptop/desktop. Add new flows to accommodate desktop computers, mobile phones, desktop computers to mobile phones (ie user wants to use their phone camera because a desktop or laptop camera generally does not have enough resolution), and mobile phones to desktop computers (ie user has a scanner). Add image previews on document uploads. Supply different verbiage for taking a picture vs. uploading an image.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md
Controllers
authenticated, make sure to add
before_action :confirm_two_factor_authenticated
as the first callback.
Database
Unsafe migrations are implemented over several PRs and over several
deploys to avoid production errors. The strong_migrations gem
will warn you about unsafe migrations and has great step-by-step instructions
for various scenarios.
Indexes were added if necessary. This article provides a good overview
of indexes in Rails.
Verified that the changes don't affect other apps (such as the dashboard)
When relevant, a rake task is created to populate the necessary DB columns
in the various environments right before deploying, taking into account the users
who might not have interacted with this column yet (such as users who have not
set a password yet)
Migrations against existing tables have been tested against a copy of the
production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
issues. In that case, all the migration did was add a new column and an index to
the Users table, which might seem innocuous.
Encryption
Routes
state or result in destructive behavior).
Session
user_session
helperinstead of the
session
helper so the data does not persist beyond the user'ssession.
Testing
and invalid inputs.