LG-744 Whitelist SP attributes for ability to receive LOA3 data

[stevegsa]

Why: Service providers should only receive loa3 data if they have been pre-configured to do so.

How: Only allow SAML and OIDC requests to accept loa3 requests if the sp is configured for ial 2. Update the existing configurations for loa3 sps in service_providers.yml. Add logic to SamlRequestValidator and OpenIdConnectAuthorizeForm.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the checklists below. These represent the more critical elements
of our code quality guidelines. The rest of the list can be found in
CONTRIBUTING.md

Controllers

• When adding a new controller that requires the user to be fully
  authenticated, make sure to add before_action :confirm_two_factor_authenticated
  as the first callback.

Database

• Unsafe migrations are implemented over several PRs and over several
  deploys to avoid production errors. The strong_migrations gem
  will warn you about unsafe migrations and has great step-by-step instructions
  for various scenarios.

• Indexes were added if necessary. This article provides a good overview
  of indexes in Rails.

• Verified that the changes don't affect other apps (such as the dashboard)

• When relevant, a rake task is created to populate the necessary DB columns
  in the various environments right before deploying, taking into account the users
  who might not have interacted with this column yet (such as users who have not
  set a password yet)

• Migrations against existing tables have been tested against a copy of the
  production database. See LG-228 Make migrations safer and more resilient #2127 for an example when a migration caused deployment
  issues. In that case, all the migration did was add a new column and an index to
  the Users table, which might seem innocuous.

Encryption

• The changes are compatible with data that was encrypted with the old code.

Routes

• GET requests are not vulnerable to CSRF attacks (i.e. they don't change
  state or result in destructive behavior).

Session

• When adding user data to the session, use the user_session helper
  instead of the session helper so the data does not persist beyond the user's
  session.

Testing

• Tests added for this feature/bug
• Prefer feature/integration specs over controller specs
• When adding code that reads data, write tests for nil values, empty strings,
  and invalid inputs.

[jmhooper]

What's the advantage of using the attribute bundle instead of the SP's ial? It seems like there's a lot more overhead involved with keeping up with the attributes for each SP rather than whether an SP is allowed to request IAL 1 or IAL 2 attributes.

[jmhooper]

I really like how this came out 💯

[jgsmith-usds]

This restricts one part of the process, but if the IAL level changes, do we restrict the identity.scopes properly? I'm thinking in particular of what we do in OpenidConnectUserInfoPresenter. It looks like we assume identity.scopes is proper, which might not be completely true if we've changed the IAL level for an SP to be more restrictive.

[brodygov]

What's the latest state here?

[stevegsa]

@jgsmith-usds I tested the scopes requesting ssn for IAL1, etc. and it correctly returned only IAL1 fields (email). wrt changing an SP's IAL level from IAL2 to IAL1 and the persisted scopes in identities: I say we create a new story for that scenario and fix it if it does not work properly.