-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor verify namespaces/urls to idv #2149
Conversation
Thanks for thinking about this. If we want consistency, we want to rename IdV to Verify, not the other way around. We originally renamed |
hmmmmm, thats informative. @jmhooper and I had spoken about this before so I thought it was something that would be helpful. We don't need to rehash the previous discussion and I can change everything to |
We could also change only the name of the routes to |
On behalf of @andrewhughey , he prefers we keep the |
I prefer |
@monfresh: Do you have any objections to using |
No objections your honor. |
A disappointing day to realize the :gavel: emoji is custom for our Slack and can't be used here 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
WHY
Some Idv related items were namespaced under
verify
while others were underidv
. This PR refactors all to be under theidv
namespace so all are consistent while differentiating from some routes that begin withverify
but are not part of the Idv flow.URLs have also been changed from
verify/
toidv/
, if this is not desired, we can remove that commit and keep the name change internally.This PR is rather large, the commits can be looked at individually to make reviewing a bit easier. There is only refactoring here, no functionality is (should be) changed.