Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-225 Remove Agency Based UUID feature flags #2124

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Apr 27, 2018

Why: To prevent reverting to old sp based uuids. This feature gave us the flexibility to turn the agency based uuids on for slow roll or rollback in the event of failures. However once the agencies migrated to the new uuid structure and the rollout is deemed error free it should not be turned off again because users could then potentially be associated with the wrong uuids.

How: Assume every logic path for the two feature flags is now true and remove unneccessary code in addition to removing the actual feature flags.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

… old SP UUIDs

**Why**: To prevent reverting to old sp based uuids which would break agencies. This feature gave us the flexibility to turn the agency based uuids on for slow roll or rollback in the event of failures. However once the agencies migrated to the new uuid structure and the rollout is error free it should not be turned off again because users would then be associated with the wrong uuids.

**How**: Assume every logic path for the two feature flags is now true and remove unneccessary code in addition to removing the actual feature flags.
@stevegsa stevegsa force-pushed the stevegsa-remove-agency-based-uuids-feature-flags branch from 400f41b to 3dd6ade Compare April 27, 2018 04:02
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevegsa stevegsa merged commit a980493 into master Apr 30, 2018
@amathews-fs amathews-fs deleted the stevegsa-remove-agency-based-uuids-feature-flags branch January 7, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants