Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpacker from 3.2.2 to 3.4.3 #2100

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Update webpacker from 3.2.2 to 3.4.3 #2100

merged 1 commit into from
Apr 19, 2018

Conversation

monfresh
Copy link
Contributor

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@monfresh monfresh force-pushed the mb-update-webpacker branch 4 times, most recently from f2dfa19 to 5fc1d58 Compare April 15, 2018 18:23
@monfresh
Copy link
Contributor Author

It seems like Circle CI is not able to see modals in JS tests after upgrading webpacker. Any ideas why? The tests are passing locally for me. I have the same version of PhantomJS. Yarn versions differ. Circle uses 1.5.1. I had an older one, and then I updated it to the latest 1.6.0 and the tests still pass.

@monfresh monfresh force-pushed the mb-update-webpacker branch 16 times, most recently from 5ec80d1 to 11702b2 Compare April 17, 2018 15:26
@monfresh
Copy link
Contributor Author

@jmhooper This is passing and ready for review now that I merged master with chromedriver.

@monfresh monfresh merged commit 09fc84e into master Apr 19, 2018
@monfresh monfresh deleted the mb-update-webpacker branch April 19, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants