Test failed and timed out jobs in shared examples #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: To make sure that job failed and timeout behavior is consistent across steps, and to provide coverage for timeout behavior which was not covered before.
jmhooper
requested review from
monfresh,
line47,
davemcorwin,
jgsmith-usds and
stevegsa
monfresh
reviewed
Apr 13, 2018
| expect(page).to have_css('.modal-warning', text: t("idv.modal.#{step_locale_key}.heading")) | ||
| expect(page).to have_css( | ||
| '.modal-warning', | ||
| text: ActionController::Base.helpers.strip_tags(t("idv.modal.#{step_locale_key}.timeout")) |
There was a problem hiding this comment.
What do you think about adding a helper method for strip_tags like you did in the other PR, so that it can be used in various tests?
There was a problem hiding this comment.
Yeah, didn't remember that it was also here. Will do once I merge that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: To make sure that job failed and timeout behavior is consistent
across steps, and to provide coverage for timeout behavior which was not
covered before.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.