Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-207 Update NGA and DOT SPs in production #2096

Merged
merged 1 commit into from
Apr 21, 2018
Merged

Conversation

stevegsa
Copy link
Contributor

@stevegsa stevegsa commented Apr 12, 2018

Why: NGA needs new redirect URIs and return_to_sp URLs. DOT needs to be added.

How: Update service_providers.yml

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@stevegsa stevegsa force-pushed the stevegsa-update-nga-sps branch from fe79809 to a3b3d45 Compare April 12, 2018 21:22
@stevegsa stevegsa force-pushed the stevegsa-update-nga-sps branch 3 times, most recently from 3d6a3b4 to 5108919 Compare April 13, 2018 19:27
@stevegsa stevegsa changed the title LG-207 Update NGA SPs in production LG-207 Update NGA and DOT SPs in production Apr 13, 2018
@stevegsa stevegsa force-pushed the stevegsa-update-nga-sps branch 2 times, most recently from 9515c12 to eaed090 Compare April 20, 2018 12:47
Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevegsa stevegsa force-pushed the stevegsa-update-nga-sps branch 2 times, most recently from 196cc1f to d2dbc38 Compare April 20, 2018 20:11
**Why**: NGA needs new redirect URIs and return_to_sp URLs

**How**: Update service_providers.yml
@stevegsa stevegsa force-pushed the stevegsa-update-nga-sps branch from c133073 to 04e3e1f Compare April 21, 2018 13:52
@stevegsa stevegsa merged commit 3accec8 into master Apr 21, 2018
@amathews-fs amathews-fs deleted the stevegsa-update-nga-sps branch January 7, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants