LG-142 Password reset should count as email confirmation #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevegsa
force-pushed
the
stevegsa-reset-password-creates-account-if-not-found
branch
from
8f1af28 to
8ad1166
Compare
monfresh
reviewed
Apr 5, 2018
| expect(mailer).to receive(:deliver_later) | ||
|
|
||
| RequestPasswordReset.new(email, 'request_id').perform | ||
| expect_any_instance_of(User).to receive(:send_custom_confirmation_instructions) |
There was a problem hiding this comment.
Would it make sense to create a new email for this scenario? It might be confusing to get an email confirming account creation when the user was trying to reset their password. Maybe we should come up with new wording that says something like "you were trying to reset your password, but you don't have an account yet, so we created one for you."
|
Reset password / confirmation email:
|
stevegsa
force-pushed
the
stevegsa-reset-password-creates-account-if-not-found
branch
2 times, most recently
from
9afb79a to
db5cf0a
Compare
**Why**: When you don't have an account and request a password reset and click through to that email that says create your account now, users are taken to the very first step of having to confirm their email address again. **How**: Override the functionality of reset password when the user is not found to behave like create account.
stevegsa
force-pushed
the
stevegsa-reset-password-creates-account-if-not-found
branch
from
c4d11ec to
d02f7e4
Compare
amathews-fs
deleted the
stevegsa-reset-password-creates-account-if-not-found
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: When you don't have an account and request a password reset and click through to that email that says create your account now, users are taken to the very first step of having to confirm their email address again.
How: Override the functionality of reset password when the user is not found to behave like create account.
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
For secrets changes, make sure to update the S3 secrets bucket with the
new configs in all environments.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.
When adding a new controller that requires the user to be fully
authenticated, make sure to add
before_action :confirm_two_factor_authenticated.