Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-123 Show OTP expiration to user on web page #2048

Merged
merged 1 commit into from
Mar 12, 2018
Merged

LG-123 Show OTP expiration to user on web page #2048

merged 1 commit into from
Mar 12, 2018

Conversation

monfresh
Copy link
Contributor

@monfresh monfresh commented Mar 10, 2018

Why: So they know up front when it will expire.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

**Why**: So they know up front when it will expire.
@monfresh
Copy link
Contributor Author

Here are screenshots for all 3 languages:
screen shot 2018-03-09 at 9 50 19 pm
screen shot 2018-03-09 at 9 50 10 pm
screen shot 2018-03-09 at 9 49 53 pm

Copy link

@micahtaylor micahtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

Copy link
Contributor

@RyanSibley RyanSibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmhooper
Copy link
Member

I'm gonna go ahead and merge this since it looks good and Moncef is offline right now.

@jmhooper jmhooper merged commit 37c8365 into master Mar 12, 2018
@amathews-fs amathews-fs deleted the mb-lg-123 branch January 7, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants