Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow users to modify international code #2033

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

jmhooper
Copy link
Member

@jmhooper jmhooper commented Mar 2, 2018

Why: So that user's will not accidentally change it while typing
their phone number

Also note that there is a change in here to allow users to continue
typing a phone number, even if libphonenumber thinks the number is
invalid. This is there to address reported issues where users could not
type their phone number into the phone number input.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • For secrets changes, make sure to update the S3 secrets bucket with the
    new configs in all environments.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

  • When adding a new controller that requires the user to be fully
    authenticated, make sure to add before_action :confirm_two_factor_authenticated.

@jmhooper jmhooper force-pushed the jmhooper-format-intl-phone-numbers branch from 16365a3 to 049e676 Compare March 2, 2018 16:46
@jmhooper jmhooper requested a review from micahtaylor March 2, 2018 16:53
@jmhooper jmhooper force-pushed the jmhooper-format-intl-phone-numbers branch from 049e676 to 71088f8 Compare March 2, 2018 16:54
@@ -1,6 +1,8 @@
import { Formatter } from 'field-kit';
import { asYouType as AsYouType } from 'libphonenumber-js';

const INTERNALTIONAL_CODE_REGEX = /^\+\d{1,3} /;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean INTERNATIONAL?

@monfresh
Copy link
Contributor

monfresh commented Mar 4, 2018

Do we have a specific example we can write a test for that shows that you can type in a number that libphonenumber thinks is invalid?

Copy link
Contributor

@monfresh monfresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

**Why**: So that user's will not accidentally change it while typing
their phone number

Also note that there is a change in here to allow users to continue
typing a phone number, even if libphonenumber thinks the number is
invalid. This is there to address reported issues where users could not
type their phone number into the phone number input.
@jmhooper jmhooper force-pushed the jmhooper-format-intl-phone-numbers branch from 71088f8 to c130edc Compare March 5, 2018 15:45
@jmhooper
Copy link
Member Author

jmhooper commented Mar 5, 2018

Do we have a specific example we can write a test for that shows that you can type in a number that libphonenumber thinks is invalid?

Yes, a US phone number with more than 10 digits. I just added a test to cover that.

@jmhooper jmhooper merged commit 2b59beb into master Mar 5, 2018
@jmhooper jmhooper deleted the jmhooper-format-intl-phone-numbers branch February 15, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants