Add deploy/build scripts to decouple build process from identity-devops. #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: Previously these deploy steps were performed by chef cookbooks in the identity-devops repo. This was an abstraction layer violation because it required identity-devops to be aware of the internals of how identity-idp builds and bootstrapps the application, which made it more difficult to make changes. **How**: Move several build steps into a build script in the identity-idp repo, which is called at boostrapping time by identity-devops cookbooks.
|
What would be the best way to test changes like the webpacker before starting the release so we'll be aware of issues? My thinking is that before we merged the PR we should have tried to deploy that code to QA. Should we do something similar here? |
|
Ideally deploys would be fast and easy enough that you can deploy a feature branch to an environment and then move it back to master. Improvements there are still a ways off. In the meantime, one option would be to split dev and qa to keep one on master and the other on a stages/env branch. Right now dev/qa both just always deploy from master, which makes it harder to test a branch prior to merging it. We can also designate a different environment for this if the dev/qa naming would be confusing. |
**Why**: The rake assets:precompile process has to be run after deploy/activate because it relies on the full database configuration being available. We still want to run as many of the build steps earlier so that they can be part of a static deploy artifact in a future build system. **How**: Create a separate build-post-config script. The full order of bootstrapping will now be: - deploy/build - deploy/activate - deploy/build-post-config
brodygov
force-pushed
the
brody/build-script
branch
from
d2a90c6 to
35a7df6
Compare
jmhooper
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these deploy steps were performed by chef cookbooks in the identity-devops repo. This made it more difficult to make changes like moving from npm to yarn or switching to webpacker because we had to tightly coordinate rolling out changes in sync between identity-idp and identity-devops.
With these changes, move build bootstrapping steps into the identity-idp repo so that the idp repo knows how to bootstrap itself.