Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to english for untranslated text #1863

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

jmhooper
Copy link
Member

Why: So that users using the site in other languages will not see
NOT TRANSLATED AT.

How: Patch I18n.translate and I18n.t such that when it is about
to return "NOT TRANSLATED AT", it instead calls back to the I18n
backend for the same translation in english.

Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:

  • For DB changes, check for missing indexes, check to see if the changes
    affect other apps (such as the dashboard), make sure the DB columns in the
    various environments are properly populated, coordinate with devops, plan
    migrations in separate steps.

  • For route changes, make sure GET requests don't change state or result in
    destructive behavior. GET requests should only result in information being
    read, not written.

  • For encryption changes, make sure it is compatible with data that was
    encrypted with the old code.

  • Do not disable Rubocop or Reek offenses unless you are absolutely sure
    they are false positives. If you're not sure how to fix the offense, please
    ask a teammate.

  • When reading data, write tests for nil values, empty strings,
    and invalid formats.

  • When calling redirect_to in a controller, use _url, not _path.

  • When adding user data to the session, use the user_session helper
    instead of the session helper so the data does not persist beyond the user's
    session.

**Why**: So that users using the site in other languages will not see
NOT TRANSLATED AT.

**How**: Patch `I18n.translate` and `I18n.t` such that when it is about
to return "NOT TRANSLATED AT", it instead calls back to the I18n
backend for the same translation in english.
@jmhooper
Copy link
Member Author

Before:
image

After:
image

@jmhooper jmhooper merged commit 668b8fc into master Dec 12, 2017
@jmhooper jmhooper deleted the jmhooper-english-fallback-translations branch December 12, 2017 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants