Make DB pool size configurable based on instance role #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhooper
reviewed
Dec 7, 2017
config/database.yml
Outdated
| @@ -5,7 +5,7 @@ postgresql: &postgresql | |||
| port: 5432 | |||
|
|
|||
| defaults: &defaults | |||
| pool: 5 | |||
| pool: <%= (File.exist?('/etc/login.gov/info') && File.read('/etc/login.gov/info/role').chomp == 'worker') ? 26 : 5 %> | |||
There was a problem hiding this comment.
Thoughts on setting this for just the prod environment, and not the default environment?
There was a problem hiding this comment.
We need this for other ends too (pt and sometimes staging)
There was a problem hiding this comment.
I think what Jonathan meant by environment was "development", "test", and "production". All the lower envs are running in the Rails "production" environment. So, he's asking to make the change in the "production" section at the bottom of this file.
__Why__ * Workers need a 5x larger pool than the IdP hosts hence we need a way to configure the pool size based on instance role. __How__ * Use a conditional to set the pool size based on the instance role type.
jgrevich
force-pushed
the
jjg/fix/configurable-db-pool-size
branch
from
0f8973c to
2b8160d
Compare
|
Updated so the config is only in rails |
jmhooper
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How