Update verify messages with app name #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nickbristow
force-pushed
the
nb-update-verified-message
branch
3 times, most recently
from
0c6a61b to
ffff41e
Compare
nickbristow
force-pushed
the
nb-update-verified-message
branch
from
ffff41e to
e95f92c
Compare
tbaxter-18f
reviewed
Dec 5, 2017
app/views/verify/fail.html.slim
Outdated
| @@ -1,10 +1,12 @@ | |||
| - title t('idv.titles.hardfail') | |||
| .clearfix | |||
| .col-10.sm-col-12.mx-auto | |||
| .center | |||
There was a problem hiding this comment.
do we need all three wrapping divs?
There was a problem hiding this comment.
That was copy pasta, no, just two should work
nickbristow
force-pushed
the
nb-update-verified-message
branch
from
e95f92c to
d7d6e0c
Compare
**Why**: Clarify which entity is verifying the users identity. Updated styles to be more consistent
tbaxter-18f
reviewed
Dec 5, 2017
| @@ -23,7 +23,7 @@ def initialize(loa3_requested:, decorated_session:, current_user:) | |||
| # rubocop:disable Rails/OutputSafety | |||
| def heading | |||
| if requested_loa == 'loa3' | |||
| content_tag(:strong, I18n.t('titles.sign_up.verified')) | |||
| content_tag(:strong, I18n.t('titles.sign_up.verified', app: APP_NAME)) | |||
There was a problem hiding this comment.
If someone went an IDP route, is APP_NAME still set to something?
There was a problem hiding this comment.
yeah, APP_NAME is always set to login.gov in our case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Clarify which entity is verifying the users
identity
Hi! Before submitting your PR for review, and/or before merging it, please
go through the following checklist:
For DB changes, check for missing indexes, check to see if the changes
affect other apps (such as the dashboard), make sure the DB columns in the
various environments are properly populated, coordinate with devops, plan
migrations in separate steps.
For route changes, make sure GET requests don't change state or result in
destructive behavior. GET requests should only result in information being
read, not written.
For encryption changes, make sure it is compatible with data that was
encrypted with the old code.
Do not disable Rubocop or Reek offenses unless you are absolutely sure
they are false positives. If you're not sure how to fix the offense, please
ask a teammate.
When reading data, write tests for nil values, empty strings,
and invalid formats.
When calling
redirect_toin a controller, use_url, not_path.When adding user data to the session, use the
user_sessionhelperinstead of the
sessionhelper so the data does not persist beyond the user'ssession.