Get rid of vendor validator abstraction

.reek

@@ -51,7 +51,7 @@ NilCheck:
 LongParameterList:
   exclude:
     - IdentityLinker#optional_attributes
-    - VendorValidatorJob#perform
+    - Idv::ProoferJob#perform
     - Idv::VendorResult#initialize
 RepeatedConditional:
   exclude:
@@ -66,6 +66,7 @@ TooManyInstanceVariables:
     - OpenidConnectAuthorizeForm
     - OpenidConnectRedirector
     - Idv::VendorResult
+    - Idv::ProoferJob
 TooManyStatements:
   max_statements: 6
   exclude:

app/controllers/verify/finance_controller.rb

@@ -41,11 +41,10 @@ def show
     private
 
     def submit_idv_job
-      SubmitIdvJob.new(
-        vendor_validator_class: Idv::FinancialsValidator,
+      Idv::SubmitIdvJob.new(
         idv_session: idv_session,
         vendor_params: vendor_params
-      ).call
+      ).submit_finance_job
     end
 
     def step_name

app/controllers/verify/phone_controller.rb

@@ -53,11 +53,10 @@ def phone_confirmation_required?
     end
 
     def submit_idv_job
-      SubmitIdvJob.new(
-        vendor_validator_class: Idv::PhoneValidator,
+      Idv::SubmitIdvJob.new(
         idv_session: idv_session,
         vendor_params: idv_session.params[:phone]
-      ).call
+      ).submit_phone_job
     end
 
     def step_name

app/controllers/verify/sessions_controller.rb

@@ -51,11 +51,10 @@ def destroy
     private
 
     def submit_idv_job
-      SubmitIdvJob.new(
-        vendor_validator_class: Idv::ProfileValidator,
+      Idv::SubmitIdvJob.new(
         idv_session: idv_session,
         vendor_params: idv_session.vendor_params
-      ).call
+      ).submit_profile_job
     end
 
     def step_name

app/jobs/idv/finance_job.rb

@@ -0,0 +1,9 @@
+module Idv
+  class FinanceJob < ProoferJob
+    def verify_identity_with_vendor
+      confirmation = agent.submit_financials(vendor_params, vendor_session_id)
+      result = extract_result(confirmation)
+      store_result(result)
+    end
+  end
+end

app/jobs/idv/phone_job.rb

@@ -0,0 +1,9 @@
+module Idv
+  class PhoneJob < ProoferJob
+    def verify_identity_with_vendor
+      confirmation = agent.submit_phone(vendor_params, vendor_session_id)
+      result = extract_result(confirmation)
+      store_result(result)
+    end
+  end
+end

app/jobs/idv/profile_job.rb

@@ -0,0 +1,23 @@
+module Idv
+  class ProfileJob < ProoferJob
+    def verify_identity_with_vendor
+      resolution = agent.start(vendor_params)
+      result = extract_result(resolution)
+      store_result(result)
+    end
+
+    private
+
+    def extract_result(resolution)
+      vendor_resp = resolution.vendor_resp
+
+      Idv::VendorResult.new(
+        success: resolution.success?,
+        errors: resolution.errors,
+        reasons: vendor_resp.reasons,
+        normalized_applicant: vendor_resp.normalized_applicant,
+        session_id: resolution.session_id
+      )
+    end
+  end
+end

app/jobs/idv/proofer_job.rb

@@ -0,0 +1,57 @@
+module Idv
+  class ProoferJob < ApplicationJob
+    queue_as :idv
+
+    attr_reader :result_id, :vendor, :vendor_params, :applicant, :vendor_session_id
+
+    def perform(result_id:, vendor:, vendor_params:, applicant_json:, vendor_session_id: nil)
+      @result_id = result_id
+      @vendor = vendor.to_sym
+      @vendor_params = vendor_params
+      @applicant = applicant_from_json(applicant_json)
+      @vendor_session_id = vendor_session_id
+      perform_identity_proofing
+    end
+
+    def verify_identity_with_vendor
+      raise NotImplementedError, "subclass must implement #{__method__}"
+    end
+
+    private
+
+    def agent
+      Idv::Agent.new(applicant: applicant, vendor: vendor)
+    end
+
+    def applicant_from_json(applicant_json)
+      applicant_attributes = JSON.parse(applicant_json, symbolize_names: true)
+      Proofer::Applicant.new(applicant_attributes)
+    end
+
+    def perform_identity_proofing
+      verify_identity_with_vendor
+    rescue StandardError
+      store_failed_job_result
+      raise
+    end
+
+    def extract_result(confirmation)
+      vendor_resp = confirmation.vendor_resp
+
+      Idv::VendorResult.new(
+        success: confirmation.success?,
+        errors: confirmation.errors,
+        reasons: vendor_resp.reasons
+      )
+    end
+
+    def store_failed_job_result
+      job_failed_result = Idv::VendorResult.new(errors: { job_failed: true })
+      VendorValidatorResultStorage.new.store(result_id: result_id, result: job_failed_result)
+    end
+
+    def store_result(vendor_result)
+      VendorValidatorResultStorage.new.store(result_id: result_id, result: vendor_result)
+    end
+  end
+end

app/services/idv/submit_idv_job.rb

@@ -0,0 +1,50 @@
+module Idv
+  class SubmitIdvJob
+    def initialize(idv_session:, vendor_params:)
+      @idv_session = idv_session
+      @vendor_params = vendor_params
+    end
+
+    def submit_profile_job
+      update_idv_session
+      ProfileJob.perform_later(proofer_job_params)
+    end
+
+    def submit_finance_job
+      update_idv_session
+      FinanceJob.perform_later(proofer_job_params)
+    end
+
+    def submit_phone_job
+      update_idv_session
+      PhoneJob.perform_later(proofer_job_params)
+    end
+
+    private
+
+    attr_reader :idv_session, :vendor_params
+
+    def proofer_job_params
+      {
+        result_id: result_id,
+        vendor: vendor.to_s,
+        vendor_params: vendor_params,
+        vendor_session_id: idv_session.vendor_session_id,
+        applicant_json: idv_session.applicant.to_json,
+      }
+    end
+
+    def result_id
+      @_result_id ||= SecureRandom.uuid
+    end
+
+    def update_idv_session
+      idv_session.async_result_id = result_id
+      idv_session.async_result_started_at = Time.zone.now.to_i
+    end
+
+    def vendor
+      idv_session.vendor || Idv::Vendor.new.pick
+    end
+  end
+end

app/services/idv/vendor_result.rb

@@ -22,11 +22,11 @@ def initialize(success: nil, errors: {}, reasons: [], session_id: nil,
     end
 
     def success?
-      success
+      success == true
     end
 
     def timed_out?
-      timed_out
+      timed_out == true
     end
 
     def job_failed?