Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package-lock.json #1757

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Update package-lock.json #1757

merged 1 commit into from
Oct 30, 2017

Conversation

monfresh
Copy link
Contributor

Why: It's like Gemfile.lock. Any changes to it must be checked
into the repo.

@monfresh
Update package-lock.json
19b0c86 
**Why**: It's like Gemfile.lock. Any changes to it must be checked
into the repo.
jmhooper
jmhooper approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did I forget to check this in when I removed app? My bad.

@tbaxter-18f
Copy link
Contributor

+1

@monfresh monfresh merged commit 30ce4f3 into master Oct 30, 2017
@monfresh monfresh deleted the mb-package-lock branch October 30, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhooper jmhooper jmhooper approved these changes

@tbaxter-18f tbaxter-18f Awaiting requested review from tbaxter-18f

Assignees
No one assigned
Labels
status - ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monfresh @tbaxter-18f @jmhooper